[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540172#comment-14540172
]
Zhe Zhang commented on HDFS-8255:
---------------------------------
Thanks Yi for the review and commit!
> Rename getBlockReplication to getPreferredBlockReplication
> ----------------------------------------------------------
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Labels: BB2015-05-TBR
> Fix For: 2.8.0
>
> Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch,
> HDFS-8255.002.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
