[ 
https://issues.apache.org/jira/browse/HDFS-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540743#comment-14540743
 ] 

Colin Patrick McCabe commented on HDFS-8358:
--------------------------------------------

bq. I would like to make TraceAdmin able to handle other config prefix such as 
"yarn.htrace.". I think SpanReceiverHost#addSpanReceiver is the right place to 
deal with the configs without prefix. Anyway we should file a new JIRA for that.

Yeah.  The user should be able to set 
"-Clocal-file-span-receiver.path=/tmp/foo" on the YARN daemons and have it 
apply the relevant YARN htrace properties.  There isn't any need to require the 
user to send '-Cyarn.htrace.local-file-span-receciver.path=...' We know that 
YARN tracing is what we want to configure, by virtue of the fact that the 
\-host argument was for a YARN host.

bq. The failure of TestHdfsConfigFields will be fixed in HDFS-8371. It should 
be addressed as separate JIRA and I will update the patch once HDFS-8371 is 
committed.

OK.

+1 for v3, can you file a follow-on JIRA to talk about the prefix issue?

> TestTraceAdmin fails
> --------------------
>
>                 Key: HDFS-8358
>                 URL: https://issues.apache.org/jira/browse/HDFS-8358
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Masatake Iwasaki
>         Attachments: HADOOP-11940.001.patch, HDFS-8358.002.patch, 
> HDFS-8358.003.patch
>
>
> After HADOOP-11912, {{TestTraceAdmin#testCreateAndDestroySpanReceiver}} in 
> hdfs started failing.
> It was probably unnoticed because the jira changed and triggered unit testing 
> in common only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to