[ 
https://issues.apache.org/jira/browse/HDFS-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541449#comment-14541449
 ] 

Zhe Zhang commented on HDFS-8201:
---------------------------------

Thanks Xinwei for the work! The patch looks good to me overall. Just a few 
minors:
# We should update JIRA description and summary. Right now the path mainly 
refactors the {{TestWriteReadStripedFile}} class
# It'd be ideal to eventually subclass {{TestWriteRead}}, in order to cover all 
test cases developed for non-EC files. This is a future we can think about.

So I'm +1 pending the JIRA update.

> Add an end to end test for stripping file writing and reading
> -------------------------------------------------------------
>
>                 Key: HDFS-8201
>                 URL: https://issues.apache.org/jira/browse/HDFS-8201
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Xinwei Qin 
>         Attachments: HDFS-8201-HDFS-7285.003.patch, 
> HDFS-8201-HDFS-7285.004.patch, HDFS-8201.001.patch, HDFS-8201.002.patch
>
>
> According to off-line discussion with [~zhz] and [~xinwei], we need to 
> implement an end to end test for stripping file support:
> * Create an EC zone;
> * Create a file in the zone;
> * Write various typical sizes of content to the file, each size maybe a test 
> method;
> * Read the written content back;
> * Compare the written content and read content to ensure it's good;
> The test facility is subject to add more steps for erasure encoding and 
> recovering. Will open separate issue for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to