[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541515#comment-14541515
]
Vinayakumar B edited comment on HDFS-6300 at 5/13/15 7:27 AM:
--------------------------------------------------------------
Latest patch looks good.
One nit in test.
{code} // release lease so that another balancer would run
assertTrue("Failed to run first balancer!",
fs.exists(Balancer.BALANCER_ID_PATH));{code}
comment is irrelevant here.
+1 once addressed.
was (Author: vinayrpet):
Latest patch looks good.
One nit in test.
{code{ // release lease so that another balancer would run
assertTrue("Failed to run first balancer!",
fs.exists(Balancer.BALANCER_ID_PATH));{code}
comment is irrelevant here.
+1 once addressed.
> Prevent multiple balancers from running simultaneously
> ------------------------------------------------------
>
> Key: HDFS-6300
> URL: https://issues.apache.org/jira/browse/HDFS-6300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Critical
> Labels: BB2015-05-RFC
> Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
> HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch, HDFS-6300.patch
>
>
> Javadoc of "Balancer.java" says, it will not allow to run second balancer if
> the first one is in progress. But I've noticed multiple can run together and
> balancer.id implementation is not safe guarding.
> {code}
> * <li>Another balancer is running. Exiting...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
