[
https://issues.apache.org/jira/browse/HDFS-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542451#comment-14542451
]
Jing Zhao commented on HDFS-8323:
---------------------------------
Thanks for working on this, Nicholas! The patch looks good to me. Some comments
but most of them can be done in separate jiras as follow-on work:
# Currently when bumping the GS we close all existing streamers which is
expensive. It will be nice we can reuse these connections. This may be a big
change thus we can do it in separate jiras.
# We can also do some code refactoring (in trunk maybe) to separate
{{setupPipelineForAppendOrRecovery}} into multiple functions for handling
different failure scenarios.
+1 for the current patch.
> Bump GenerationStamp for write faliure in DFSStripedOutputStream
> ----------------------------------------------------------------
>
> Key: HDFS-8323
> URL: https://issues.apache.org/jira/browse/HDFS-8323
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h8323_20150511.patch, h8323_20150511b.patch,
> h8323_20150512.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
