[
https://issues.apache.org/jira/browse/HDFS-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543148#comment-14543148
]
Hadoop QA commented on HDFS-8394:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 42s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 40s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 16s | The applied patch generated
25 new checkstyle issues (total was 476, now 485). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 6s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 180m 43s | Tests failed in hadoop-hdfs. |
| | | 223m 42s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| | Redundant nullcheck of targets, which is known to be non-null in
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(String,
long, String, ExtendedBlock, DatanodeInfo[], String[]) Redundant null check at
FSNamesystem.java:is known to be non-null in
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(String,
long, String, ExtendedBlock, DatanodeInfo[], String[]) Redundant null check at
FSNamesystem.java:[line 3067] |
| Failed unit tests |
hadoop.hdfs.server.namenode.TestCommitBlockSynchronization |
| | hadoop.tools.TestHdfsConfigFields |
| Timed out tests | org.apache.hadoop.hdfs.TestDFSClientRetries |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732715/HDFS-8394.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0e85044 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10963/console |
This message was automatically generated.
> Move getAdditionalBlock() and related functionalities into a separate class
> ---------------------------------------------------------------------------
>
> Key: HDFS-8394
> URL: https://issues.apache.org/jira/browse/HDFS-8394
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-8394.000.patch, HDFS-8394.001.patch,
> HDFS-8394.002.patch
>
>
> This jira proposes to move the implementation of getAdditionalBlock() and
> related functionalities to a separate class to open up the possibilities of
> further refactoring and improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
