[
https://issues.apache.org/jira/browse/HDFS-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544351#comment-14544351
]
Tsz Wo Nicholas Sze commented on HDFS-7559:
-------------------------------------------
Hi, have you tried to run the new test yourself?
{code}
Running org.apache.hadoop.hdfs.tools.TestHdfsConfigFields
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.673 sec <<<
FAILURE! - in org.apache.hadoop.hdfs.tools.TestHdfsConfigFields
testCompareXmlAgainstConfigurationClass(org.apache.hadoop.hdfs.tools.TestHdfsConfigFields)
Time elapsed: 0.526 sec <<< FAILURE!
java.lang.AssertionError: hdfs-default.xml has 2 properties missing in class
org.apache.hadoop.hdfs.DFSConfigKeys
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.hadoop.conf.TestConfigurationFieldsBase.testCompareXmlAgainstConfigurationClass(TestConfigurationFieldsBase.java:468)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Running org.apache.hadoop.tools.TestHdfsConfigFields
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.098 sec <<<
FAILURE! - in org.apache.hadoop.tools.TestHdfsConfigFields
testCompareXmlAgainstConfigurationClass(org.apache.hadoop.tools.TestHdfsConfigFields)
Time elapsed: 0.009 sec <<< ERROR!
java.lang.Error: Unresolved compilation problem:
The declared package "org.apache.hadoop.hdfs.tools" does not match the
expected package "org.apache.hadoop.tools"
at
org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19)
testCompareConfigurationClassAgainstXml(org.apache.hadoop.tools.TestHdfsConfigFields)
Time elapsed: 0 sec <<< ERROR!
java.lang.Error: Unresolved compilation problem:
The declared package "org.apache.hadoop.hdfs.tools" does not match the
expected package "org.apache.hadoop.tools"
at
org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19)
{code}
> Create unit test to automatically compare HDFS related classes and
> hdfs-default.xml
> -----------------------------------------------------------------------------------
>
> Key: HDFS-7559
> URL: https://issues.apache.org/jira/browse/HDFS-7559
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Priority: Minor
> Labels: supportability
> Fix For: 2.8.0
>
> Attachments: HDFS-7559.001.patch, HDFS-7559.002.patch,
> HDFS-7559.003.patch, HDFS-7559.004.patch
>
>
> Create a unit test that will automatically compare the fields in the various
> HDFS related classes and hdfs-default.xml. It should throw an error if a
> property is missing in either the class or the file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
