[
https://issues.apache.org/jira/browse/HDFS-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545133#comment-14545133
]
Kai Zheng commented on HDFS-8367:
---------------------------------
Kai thanks for your update. Would you help remove the following unnecessary
TODOs? Thanks.
1. In {{FSEditLogLoader}}, there are 4 cases like below:
{code}
// TODO whether the file is striped should later be retrieved from iip
- updateBlocks(fsDir, addCloseOp, iip, newFile, fsDir.isInECZone(iip));
+ updateBlocks(fsDir, addCloseOp, iip, newFile,
+ fsDir.getECSchema(iip), fsDir.isInECZone(iip));
{code}
2. In {{FSImageFormat}}, 1 case:
{code}
- blocks[j] = new BlockInfoStriped(new Block(),
- HdfsConstants.NUM_DATA_BLOCKS, HdfsConstants.NUM_PARITY_BLOCKS);
+ // TODO: ECSchema can be restored from persisted file (HDFS-7859).
+ blocks[j] = new BlockInfoStriped(new Block(), schema);
{code}
+1 pending on above minors and Jenkins building.
> BlockInfoStriped can also receive schema at its creation
> --------------------------------------------------------
>
> Key: HDFS-8367
> URL: https://issues.apache.org/jira/browse/HDFS-8367
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Labels: EC
> Attachments: HDFS-8367-FYI-v2.patch, HDFS-8367-FYI.patch,
> HDFS-8367-HDFS-7285-01.patch, HDFS-8367-HDFS-7285-02.patch,
> HDFS-8367.1.patch, HDFS-8467-HDFS-7285-03.patch, HDFS-8467-HDFS-7285-04.patch
>
>
> {{BlockInfoStriped}} should receive the total information for erasure coding
> as {{ECSchema}}. This JIRA changes the constructor interface and its
> dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
