[
https://issues.apache.org/jira/browse/HDFS-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545482#comment-14545482
]
Hadoop QA commented on HDFS-8390:
---------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 33s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 31s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 49s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 1s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 15s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 168m 15s | Tests passed in hadoop-hdfs.
|
| | | 209m 36s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12733102/HDFS-8390.004.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1ea9014 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11000/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11000/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11000/console |
This message was automatically generated.
> merge BlockPlacementPolicyWithNodeGroup with default policy
> -----------------------------------------------------------
>
> Key: HDFS-8390
> URL: https://issues.apache.org/jira/browse/HDFS-8390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-8390.001.patch, HDFS-8390.002.patch,
> HDFS-8390.003.patch, HDFS-8390.004.patch
>
>
> We saw requirements for adding new policies.( HDFS-7613, HDFS-7892,
> HDFS-8131, maybe HDFS-4894, HDFS-7068 in the future). Every policy need to
> support NodeGroup.
> Assume we have N policies:
> {noformat}
> BlockPlacementPolicyDefault
> BlockPlacementPolicyCustomized1 extends BlockPlacementPolicyDefault
> BlockPlacementPolicyCustomized2 extends BlockPlacementPolicyDefault
> BlockPlacementPolicyCustomized3 extends BlockPlacementPolicyDefault
> {noformat}
> We need to implements another N policies:
> {noformat}
> BlockPlacementPolicyyWithNodeGroup
> BlockPlacementPolicyCustomized1WithNodeGroup extends
> BlockPlacementPolicyWithNodeGroup
> BlockPlacementPolicyCustomized2WithNodeGroup extends
> BlockPlacementPolicyWithNodeGroup
> BlockPlacementPolicyCustomized3WithNodeGroup extends
> BlockPlacementPolicyWithNodeGroup
> {noformat}
> We had better merge nodeGroup awareness into default policy. So every new
> policy only need to extends BlockPlacementPolicyDefault.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
