[ 
https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HDFS-7101:
-------------------------
    Description: 
{code}
    String lastLine = null;
    int errCode = -1;
    try {
      while ((line = input.readLine()) != null) {
...
    if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
      errCode = 0;
{code}

If readLine() throws exception, lastLine may be null, leading to NPE.

  was:
{code}
    String lastLine = null;
    int errCode = -1;
    try {
      while ((line = input.readLine()) != null) {
...
    if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
      errCode = 0;
{code}
If readLine() throws exception, lastLine may be null, leading to NPE.


> Potential null dereference in DFSck#doWork()
> --------------------------------------------
>
>                 Key: HDFS-7101
>                 URL: https://issues.apache.org/jira/browse/HDFS-7101
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.5.1
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-7101_001.patch
>
>
> {code}
>     String lastLine = null;
>     int errCode = -1;
>     try {
>       while ((line = input.readLine()) != null) {
> ...
>     if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
>       errCode = 0;
> {code}
> If readLine() throws exception, lastLine may be null, leading to NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to