[ 
https://issues.apache.org/jira/browse/HDFS-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555002#comment-14555002
 ] 

Haohui Mai commented on HDFS-8377:
----------------------------------

Thanks for working on this. A couple high-level comments:

1. I think it makes sense to minimize the patch. Things like limiting the 
amount of handlers can be done in separate jiras.
2. The application layer and the transport layer need to be separated -- which 
avoids copying all the code.
3. Please keep in mind that the goal is not to build a general HTTP/2 server. I 
don't see a need to support upgrading connections to HTTP/2, considering subtle 
issues like TLS renegotiation vulnerabilities.
4. It seems unnecessary to change the visibility scope of multiple classes. It 
might be better to put HTTP/2 related code into the same package.
5. Given what we have in the shell script today, it might be difficult to 
deploy jetty-alpn. It might make sense to switch to netty-tcnative for the ease 
of deployment given that Hadoop is shipping multiple pieces of native code 
(e.g., crc, short circuit reads, leveldb) already.


> Support HTTP/2 in datanode
> --------------------------
>
>                 Key: HDFS-8377
>                 URL: https://issues.apache.org/jira/browse/HDFS-8377
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: zhangduo
>            Assignee: zhangduo
>         Attachments: HDFS-8377.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to