[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555223#comment-14555223
]
Andrew Wang commented on HDFS-8306:
-----------------------------------
I like it! Just a few nitty review comments:
* Some typos in layoutVersion javadoc: "it to after" "he fsimage"
* the new IOException on bad version, maybe say "Fsimage %s has metadata
version of %d which is newer than the latest metadata version supported by this
OIV tool (%d)."
+1 pending these small ones
> Generate ACL and Xattr outputs in OIV XML outputs
> -------------------------------------------------
>
> Key: HDFS-8306
> URL: https://issues.apache.org/jira/browse/HDFS-8306
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
> HDFS-8306.002.patch, HDFS-8306.003.patch
>
>
> Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
> outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
> Also it prevents recovering a fsimage from XML file.
> This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
> achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
