[ 
https://issues.apache.org/jira/browse/HDFS-8481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562434#comment-14562434
 ] 

Walter Su commented on HDFS-8481:
---------------------------------

*A*
decodeAndFillBuffer(..) has multiple functions, and is hard to read.
1. copy {{alignedStripe}} to {{decodeInputs}}
2. decode {{decodeInputs}} to {{outputs}}
3. copy {{outputs}} to {{buf}}

To me, {{decodeInputs}} should be prepared before calling 
{{decodeAndFillBuffer}}. How about we let caller do the 1st job? Or make 1st 
job an independent function so caller can call it.
*B*
buf[] is given by user. User will reuse it.
We should reuse decodeInputs[][] inside. Memory maybe cheap to client, but is 
precious to Datanode. We can improve this in another jira.


> Erasure coding: remove workarounds for codec calculation
> --------------------------------------------------------
>
>                 Key: HDFS-8481
>                 URL: https://issues.apache.org/jira/browse/HDFS-8481
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8481-HDFS-7285.00.patch, 
> HDFS-8481-HDFS-7285.01.patch
>
>
> After HADOOP-11847 and related fixes, we should be able to properly calculate 
> decoded contents.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to