[
https://issues.apache.org/jira/browse/HDFS-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564392#comment-14564392
]
Yi Liu commented on HDFS-8328:
------------------------------
Thanks Kai for comments.
{quote}
{{minRequiredSources}} looks like a little confusing, because from coder's
point of view
{quote}
This is not from coder's point of view, it's unrelated to coder. sources means
datanodes which contain correct striped block.
{quote}
How about renaming nullInputBuffers to nullCellBuffers
{quote}
Currently in DN, decode buffer size is not same as cell size. I have comment
{{// striped block length is 0}}, maybe I can change it to {{//The buffers and
indices for striped blocks whose length is 0}}, and change the name to
{{ZeroStripeBuffers}} and {{ZeroStripeIndices}}.
{quote}
I guess the following utilities can be moved elsewhere and shared with client
side. targetsStatus could have a better name.
{quote}
{{covertIndex4Decode}} can be shared, I will move it to {{StripedBlockUtil}}.
{quote}
I'm wondering if the following codes can be better organized, like all the
codes can be split into two functions: newStrippedReader and newBlockReader.
{quote}
The {{newBlockReader}} is already a separate function.
{quote}
Is it easy to centralize all the input/output buffers allocation in a function,
so in future it would be easier to enhance respecting the fact that Java coders
like on-heap buffer, but native coders prefer direct buffer.
{quote}
Agree, we can have a function for allocating buffer.
> Follow-on to update decode for DataNode striped blocks reconstruction
> ---------------------------------------------------------------------
>
> Key: HDFS-8328
> URL: https://issues.apache.org/jira/browse/HDFS-8328
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-8328-HDFS-7285.001.patch
>
>
> Current the decode for DataNode striped blocks reconstruction is a
> workaround, we need to update it after the decode fix in HADOOP-11847.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
