[
https://issues.apache.org/jira/browse/HDFS-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566953#comment-14566953
]
Jitendra Nath Pandey commented on HDFS-8392:
--------------------------------------------
[~arpitagarwal], the patch looks very good. I have couple of minor comments.
# Datanode#getFSDataset(), getDirectoryScanner : Please annotate it as
deprecated, and probably we should remove @VisibleForTesting, so that new tests
are not written using these methods.
# Ideally we should change the tests to use the datasetsMap instead of
legacy field 'data'. That can be taken in a separate jira.
I am +1 with the patch.
> DataNode support for multiple datasets
> --------------------------------------
>
> Key: HDFS-8392
> URL: https://issues.apache.org/jira/browse/HDFS-8392
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8392-HDFS-7240.01.patch,
> HDFS-8392-HDFS-7240.02.patch, HDFS-8392-HDFS-7240.03.patch
>
>
> For HDFS-7240 we would like to share available DataNode storage across HDFS
> blocks and Ozone objects.
> The DataNode already supports sharing available storage across multiple block
> pool IDs for the federation feature. However all federated block pools use
> the same dataset implementation i.e. {{FsDatasetImpl}}.
> We can extend the DataNode to support multiple dataset implementations so the
> same storage space can be shared across one or more HDFS block pools and one
> or more Ozone block pools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
