[
https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925912#action_12925912
]
Eli Collins commented on HDFS-1462:
-----------------------------------
+1
Nit: In FSNamesytem#adjustReplication typo "replicatoin" And please add spacing
around operators.
Otherwise looks great. Agree with removing the last log. This was added in
HADOOP-4045, I checked that change and didn't find any other logs that fire
with every edit.
> Refactor edit log loading to a separate class from edit log writing
> -------------------------------------------------------------------
>
> Key: HDFS-1462
> URL: https://issues.apache.org/jira/browse/HDFS-1462
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt,
> hdfs-1462.txt
>
>
> Before the major work in HDFS-1073, I'd like to do this refactor to clean up
> the monster FSEditLog class. We can separate all the functions that take of
> loading edits into an FSN from the functions that take care of writing edits,
> rolling, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.