[
https://issues.apache.org/jira/browse/HDFS-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567662#comment-14567662
]
Jing Zhao commented on HDFS-8489:
---------------------------------
The 04 patch looks pretty good to me. One nitty pick is that looks like we do
not need to declare {{setPrevious}} and {{setNext}} as protected? Maybe only
make them as package default? Other than this +1.
> Subclass BlockInfo to represent contiguous blocks
> -------------------------------------------------
>
> Key: HDFS-8489
> URL: https://issues.apache.org/jira/browse/HDFS-8489
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-8489.00.patch, HDFS-8489.01.patch,
> HDFS-8489.02.patch, HDFS-8489.03.patch, HDFS-8489.04.patch
>
>
> As second step of the cleanup, we should make {{BlockInfo}} an abstract class
> and merge the subclass {{BlockInfoContiguous}} from HDFS-7285 into trunk. The
> patch should clearly separate where to use the abstract class versus the
> subclass.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
