[ 
https://issues.apache.org/jira/browse/HDFS-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569494#comment-14569494
 ] 

Andrew Wang commented on HDFS-8386:
-----------------------------------

Thanks [~rakeshr] for the update. I like the getter and setter proposal #1, it 
seems cleaner. Could we name it setStreamer instead of updateStreamer too, to 
follow the normal naming convention? Otherwise LGTM.

> Improve synchronization of 'streamer' reference in DFSOutputStream - accessed 
> inconsistently with respect to synchronization
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8386
>                 URL: https://issues.apache.org/jira/browse/HDFS-8386
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8386-00.patch
>
>
> Presently {{DFSOutputStream#streamer}} object reference is accessed 
> inconsistently with respect to synchronization. It would be good to improve 
> this part. This has been noticed when implementing the erasure coding feature.
> Please refer the related [discussion 
> thread|https://issues.apache.org/jira/browse/HDFS-8294?focusedCommentId=14541411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14541411]
>  in the jira HDFS-8294 for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to