[
https://issues.apache.org/jira/browse/HDFS-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575254#comment-14575254
]
Zhe Zhang commented on HDFS-8433:
---------------------------------
Thanks Walter for the work.
# The overall approach of using {{BlockIdRange}} LGTM. If there are no legacy
random block IDs it would be much simpler. But considering legacy IDs we do
need such a data structure to explicitly set the acceptable range.
# Could you rebase the patch?
# When rebasing, if possible, could you also split the patch and separate the
new retry logic into another JIRA? That will make reviewing much easier.
> blockToken is not set in constructInternalBlock and parseStripedBlockGroup in
> StripedBlockUtil
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-8433
> URL: https://issues.apache.org/jira/browse/HDFS-8433
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Walter Su
> Attachments: HDFS-8433.00.patch
>
>
> The blockToken provided in LocatedStripedBlock is not used to create
> LocatedBlock in constructInternalBlock and parseStripedBlockGroup in
> StripedBlockUtil.
> We should also add ec tests with security on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
