[ https://issues.apache.org/jira/browse/HDFS-8540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576781#comment-14576781 ]
Hadoop QA commented on HDFS-8540: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 17m 49s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 31s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 16s | The applied patch generated 2 new checkstyle issues (total was 18, now 20). | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 36s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 3m 17s | The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 15s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 161m 44s | Tests failed in hadoop-hdfs. | | | | 208m 6s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdfs | | Failed unit tests | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.server.mover.TestStorageMover | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12738157/HDFS-8540.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / a6cb489 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/artifact/patchprocess/whitespace.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11265/console | This message was automatically generated. > Mover should exit with NO_MOVE_BLOCK if no block can be moved > ------------------------------------------------------------- > > Key: HDFS-8540 > URL: https://issues.apache.org/jira/browse/HDFS-8540 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Reporter: Tsz Wo Nicholas Sze > Assignee: surendra singh lilhore > Attachments: HDFS-8540.patch > > > When there are files not satisfying their storage policy and no move is > possible, Mover exits with SUCCESS. It should exit with NO_MOVE_BLOCK. > The bug seems in the following code. When StorageTypeDiff is not empty and > scheduleMoves4Block return false, it does not update hasRemaining. Also, > there is no indication of "No block can be moved" for the entire iteration. > {code} > //Mover.processFile(..) > if (!diff.removeOverlap(true)) { > if (scheduleMoves4Block(diff, lb, ecSchema)) { > hasRemaining |= (diff.existing.size() > 1 && > diff.expected.size() > 1); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)