[
https://issues.apache.org/jira/browse/HDFS-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578854#comment-14578854
]
Tony Reix commented on HDFS-8520:
---------------------------------
Hi Andrew
I'm working on this branch 2.7 as a first priority for us.
Looking at your next comment, it looks like the patch is OK for the trunk ?
correct ?
About the issue we see without the patch, yes that deals with PageRounder and
the test TestFsDatasetCache . However, the error message does not provide clear
hint about the deep issue, since the tests end with "Time out". So it was a
real pain to understand the root cause.
About adding tests dealing with PPC64 as you said, I think it is more general :
consider that page size is not always 4096 is enough.
In addition, searching through HADOOP code, I've found about 100 definitions of
PAGE SIZE or CACHE SIZE with different value, or with 4096 hard coded, mainly
(or all) in test code. These places do not generate issues on PPC64, but it may
lead to issues on other platforms maybe.
Last thing, we have found another place in the test code that generates a test
error: TestFsDatasetCacheRevocation.java .
I'll add a second version of the patch, with a 1 line change. I've checked that
the patch applies fine:
patching file
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCacheRevocation.java
Hunk #1 succeeded at 57 (offset -1 lines).
> Patch for PPC64 block size
> --------------------------
>
> Key: HDFS-8520
> URL: https://issues.apache.org/jira/browse/HDFS-8520
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.1
> Environment: RHEL 7.1 /PPC64
> Reporter: Tony Reix
> Assignee: Tony Reix
> Fix For: 2.7.1
>
> Attachments: HDFS-8520.patch
>
>
> The attached patch enables Hadoop to work on PPC64.
> That deals with SystemPageSize and BloclSize , which are not 4096 on PPC64.
> There are changes in 3 files:
> -
> hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
> -
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCache.java
> -
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
> where 4096 is replaced by getOperatingSystemPageSize() or by using PAGE_SIZE
> The patch has been built on branch-2.7 .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
