[ 
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580323#comment-14580323
 ] 

Vinayakumar B commented on HDFS-8450:
-------------------------------------

Latest patch looks almost good. We are near to make it final.
Just one more change,

In NamenodeFsck.java, include below code also inside readLock, because there 
could be chances of file getting deleted at same time. if not under readlock, 
later problems will come.
{code}         INode inode = 
namenode.getNamesystem().getFSDirectory().getINode(path);
         INodesInPath iip = INodesInPath.fromINode(inode);{code}

+1 once this is addressed.

> Erasure Coding: Consolidate erasure coding zone related implementation into a 
> single class
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8450
>                 URL: https://issues.apache.org/jira/browse/HDFS-8450
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch, 
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch, 
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch, 
> HDFS-8450-HDFS-7285-05.patch, HDFS-8450-HDFS-7285-07.patch, 
> HDFS-8450-HDFS-7285-08.patch, HDFS-8450-HDFS-7285-09.patch, 
> HDFS-8450-HDFS-7285-10.patch, HDFS-8450-HDFS-7285-11.patch, 
> HDFS-8450-HDFS-7285-12.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good  to 
> consolidate all the erasure coding zone related implementations of 
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have 
> functions to perform related erasure coding zone operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to