[ 
https://issues.apache.org/jira/browse/HDFS-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581265#comment-14581265
 ] 

Zhe Zhang commented on HDFS-8543:
---------------------------------

Thanks Walter for working on this! The main logic of 
{{chooseExcessReplicates4Stripe}} looks reasonable.

# The name {{ExcessReplicates}} should be {{ExcessReplicas}}. It was originated 
in trunk. I will file a separate JIRA to address.
# We could assert the type before casting:
{code}
BlockInfoStriped sblk = (BlockInfoStriped) storedBlock;
{code}
# It seems no value is ever inserted into {{used}}?
# {{dulplicated}} misspelled
# The 2 versions of {{chooseExcessReplicates}} should be _contiguous_ and 
_striped_, instead of _replication_ and _stripe_.

Will review again when above issues are addressed, especially #3.

> Erasure Coding: processOverReplicatedBlock() handles striped block
> ------------------------------------------------------------------
>
>                 Key: HDFS-8543
>                 URL: https://issues.apache.org/jira/browse/HDFS-8543
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8543-HDFS-7285.01.patch
>
>
> striped block group could be over replicated when: 1.dead DN comes back. 2. 
> Balancer/Mover copies block before deletes it.
> This jira add logic for processOverReplicatedBlock() handling striped block



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to