[ 
https://issues.apache.org/jira/browse/HDFS-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583424#comment-14583424
 ] 

Yi Liu commented on HDFS-8499:
------------------------------

Thanks Zhe for the patch.  Sorry there is a confusion for the comments:
Seems you modified the patch based on {{04}},  so missed my another comment 
again (We should include what you did in {{05}} about "The update patch also 
moves the implementation of 3 methods to BIUCContiguous: setExpectedLocations, 
getTruncateBlock and setTruncateBlock").  
So I mean we modify the patch based on {{05}}, just  keep the static methods in 
{{ContiguousBlockStorageOp}}.  

+1 after addressing.

> Merge BlockInfoUnderConstruction into trunk
> -------------------------------------------
>
>                 Key: HDFS-8499
>                 URL: https://issues.apache.org/jira/browse/HDFS-8499
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8499.00.patch, HDFS-8499.01.patch, 
> HDFS-8499.02.patch, HDFS-8499.03.patch, HDFS-8499.04.patch, 
> HDFS-8499.05.patch, HDFS-8499.06.patch, HDFS-8499.UCFeature.patch
>
>
> In HDFS-7285 branch, the {{BlockInfoUnderConstruction}} interface provides a 
> common abstraction for striped and contiguous UC blocks. This JIRA aims to 
> merge it to trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to