[ https://issues.apache.org/jira/browse/HDFS-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Liu updated HDFS-8587: ------------------------- Resolution: Duplicate Status: Resolved (was: Patch Available) OK. This jira itself is small, I agree with you. Please allow me to close this one first. And after the merge, you can update patch if there is some issue left. Thanks Vinay for the attention. > Erasure Coding: fix the copy constructor of BlockInfoStriped and > BlockInfoContiguous > ------------------------------------------------------------------------------------ > > Key: HDFS-8587 > URL: https://issues.apache.org/jira/browse/HDFS-8587 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Yi Liu > Assignee: Vinayakumar B > Attachments: HDFS-8587-HDFS-7285.001.patch, > HDFS-8587-HDFS-7285.002.patch > > > {code} > BlockInfoStriped(BlockInfoStriped b) { > this(b, b.getSchema()); > this.setBlockCollection(b.getBlockCollection()); > } > {code} > {code} > protected BlockInfoContiguous(BlockInfoContiguous from) { > this(from, from.getBlockCollection().getPreferredBlockReplication()); > this.triplets = new Object[from.triplets.length]; > this.setBlockCollection(from.getBlockCollection()); > } > {code} > We should define a copy constructor in the {{BlockInfo}}, and call it from > these two {{subclass}}. I also notice a NullPointerException test failure > of {{TestBlockInfo.testCopyConstructor}} in latest branch which is related to > this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)