[
https://issues.apache.org/jira/browse/HDFS-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585824#comment-14585824
]
Hadoop QA commented on HDFS-8606:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 45s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 25s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 17s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 13s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 162m 3s | Tests passed in hadoop-hdfs.
|
| | | 208m 9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12739567/HDFS-8606-00.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4c5da9b |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11355/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11355/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11355/console |
This message was automatically generated.
> Cleanup DFSOutputStream by removing unwanted changes
> ----------------------------------------------------
>
> Key: HDFS-8606
> URL: https://issues.apache.org/jira/browse/HDFS-8606
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Minor
> Attachments: HDFS-8606-00.patch
>
>
> This jira is to clean up few changes done as part of HDFS-8386. As per
> [~szetszwo] comments, it will affect the write performance. Please see the
> discussion
> [here|https://issues.apache.org/jira/browse/HDFS-8386?focusedCommentId=14575386&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14575386]
> Needs to do the following changes as part of this jira:
> # remove “synchronized" from getStreamer() since it may unnecessarily block
> the caller
> # remove setStreamer(..) which is currently not used. We may add it in the
> HDFS-7285 branch and see how to do synchronization correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
