[
https://issues.apache.org/jira/browse/HDFS-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586325#comment-14586325
]
Arpit Agarwal commented on HDFS-8607:
-------------------------------------
+1 for the patch, nice catch! Committing it shortly.
> TestFileCorruption doesn't work as expected
> -------------------------------------------
>
> Key: HDFS-8607
> URL: https://issues.apache.org/jira/browse/HDFS-8607
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-8607.01.patch
>
>
> Although it passes, it's useless.
> {code}
> 77 File[] blocks = data_dir.listFiles();
> 78 assertTrue("Blocks do not exist in data-dir", (blocks != null) &&
> (blocks.length > 0));
> 79 for (int idx = 0; idx < blocks.length; idx++) {
> 80 if (!blocks[idx].getName().startsWith(Block.BLOCK_FILE_PREFIX)) {
> 81 continue;
> 82 }
> 83 System.out.println("Deliberately removing file
> "+blocks[idx].getName());
> 84 assertTrue("Cannot remove file.", blocks[idx].delete());
> 85 }
> {code}
> blocks are located at finalized/subdir0/subdir0, but line 77 only returns
> "subdir0" because {{File.listFiles()}} is not recursive. So line 83~84 will
> never be excuted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
