[ https://issues.apache.org/jira/browse/HDFS-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588021#comment-14588021 ]
Hadoop QA commented on HDFS-8238: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 18m 48s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 38s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 47s | The applied patch generated 127 new checkstyle issues (total was 35, now 162). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 39s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 4m 8s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 17s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 121m 58s | Tests failed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 0m 17s | Tests passed in hadoop-hdfs-client. | | | | 170m 17s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots | | | hadoop.fs.TestUrlStreamHandler | | | hadoop.hdfs.server.namenode.TestFileLimit | | | hadoop.hdfs.server.namenode.TestEditLogAutoroll | | | hadoop.TestRefreshCallQueue | | | hadoop.hdfs.protocolPB.TestPBHelper | | | hadoop.cli.TestCryptoAdminCLI | | | hadoop.fs.viewfs.TestViewFsWithAcls | | | hadoop.hdfs.server.namenode.TestFSEditLogLoader | | | hadoop.fs.contract.hdfs.TestHDFSContractDelete | | | hadoop.fs.TestFcHdfsSetUMask | | | hadoop.fs.TestUnbuffer | | | hadoop.hdfs.server.namenode.TestClusterId | | | hadoop.hdfs.server.namenode.TestDeleteRace | | | hadoop.hdfs.server.namenode.TestFSDirectory | | | hadoop.fs.contract.hdfs.TestHDFSContractOpen | | | hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing | | | hadoop.hdfs.server.namenode.TestFileTruncate | | | hadoop.fs.contract.hdfs.TestHDFSContractMkdir | | | hadoop.fs.contract.hdfs.TestHDFSContractAppend | | | hadoop.hdfs.server.namenode.TestSecondaryWebUi | | | hadoop.hdfs.server.namenode.TestHDFSConcat | | | hadoop.hdfs.server.namenode.TestAddBlockRetry | | | hadoop.fs.TestSymlinkHdfsFileSystem | | | hadoop.fs.viewfs.TestViewFsDefaultValue | | | hadoop.fs.TestSymlinkHdfsFileContext | | | hadoop.hdfs.TestClientProtocolForPipelineRecovery | | | hadoop.hdfs.TestFSInputChecker | | | hadoop.hdfs.server.mover.TestStorageMover | | | hadoop.cli.TestAclCLI | | | hadoop.hdfs.TestEncryptedTransfer | | | hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional | | | hadoop.fs.contract.hdfs.TestHDFSContractSeek | | | hadoop.hdfs.server.namenode.TestFileContextXAttr | | | hadoop.hdfs.server.namenode.TestAclConfigFlag | | | hadoop.hdfs.server.namenode.TestFSImageWithXAttr | | | hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics | | | hadoop.tracing.TestTracing | | | hadoop.hdfs.server.namenode.TestListCorruptFileBlocks | | | hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot | | | hadoop.hdfs.server.namenode.TestGenericJournalConf | | | hadoop.fs.viewfs.TestViewFsWithXAttrs | | | hadoop.hdfs.server.namenode.TestEditLogJournalFailures | | | hadoop.hdfs.TestPersistBlocks | | | hadoop.hdfs.TestDatanodeReport | | | hadoop.tools.TestJMXGet | | | hadoop.fs.contract.hdfs.TestHDFSContractCreate | | | hadoop.hdfs.server.namenode.TestCreateEditsLog | | | hadoop.hdfs.server.namenode.TestFSNamesystemMBean | | | hadoop.hdfs.TestWriteRead | | | hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes | | | hadoop.fs.TestEnhancedByteBufferAccess | | | hadoop.fs.TestFcHdfsPermission | | | hadoop.security.TestRefreshUserMappings | | | hadoop.fs.viewfs.TestViewFsHdfs | | | hadoop.fs.TestResolveHdfsSymlink | | | hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps | | | hadoop.tracing.TestTracingShortCircuitLocalRead | | | hadoop.hdfs.server.namenode.TestDecommissioningStatus | | | hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots | | | hadoop.tracing.TestTraceAdmin | | | hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics | | | hadoop.hdfs.server.namenode.TestNNThroughputBenchmark | | | hadoop.hdfs.server.namenode.TestAuditLogAtDebug | | | hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs | | | hadoop.hdfs.server.namenode.TestQuotaByStorageType | | | hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer | | | hadoop.hdfs.server.namenode.TestNamenodeRetryCache | | | hadoop.hdfs.server.balancer.TestBalancer | | | hadoop.fs.TestFcHdfsCreateMkdir | | | hadoop.hdfs.server.namenode.TestBlockUnderConstruction | | | hadoop.hdfs.server.mover.TestMover | | | hadoop.hdfs.server.namenode.TestDeadDatanode | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.namenode.TestCacheDirectives | | | hadoop.hdfs.server.namenode.TestCommitBlockSynchronization | | | hadoop.hdfs.server.namenode.TestFSNamesystem | | | hadoop.fs.viewfs.TestViewFileSystemWithXAttrs | | | hadoop.fs.viewfs.TestViewFileSystemWithAcls | | | hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot | | | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes | | | hadoop.security.TestPermission | | | hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup | | | hadoop.fs.contract.hdfs.TestHDFSContractConcat | | | hadoop.hdfs.server.namenode.TestStartupProgressServlet | | | hadoop.hdfs.server.namenode.TestFSPermissionChecker | | | hadoop.hdfs.server.namenode.TestLargeDirectoryDelete | | | hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade | | | hadoop.security.TestPermissionSymlinks | | | hadoop.hdfs.server.namenode.TestValidateConfigurationSettings | | | hadoop.net.TestNetworkTopology | | | hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory | | | hadoop.cli.TestXAttrCLI | | | hadoop.hdfs.TestEncryptionZonesWithHA | | | hadoop.fs.contract.hdfs.TestHDFSContractRename | | | hadoop.hdfs.server.namenode.TestSecurityTokenEditLog | | | hadoop.fs.permission.TestStickyBit | | | hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot | | | hadoop.hdfs.server.namenode.TestTransferFsImage | | | hadoop.hdfs.server.namenode.TestGetBlockLocations | | | hadoop.hdfs.server.namenode.TestFSImageWithSnapshot | | | hadoop.hdfs.TestPipelines | | | hadoop.fs.loadGenerator.TestLoadGenerator | | | hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename | | | hadoop.hdfs.server.namenode.TestStartupOptionUpgrade | | | hadoop.cli.TestCacheAdminCLI | | | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport | | | hadoop.fs.TestHDFSFileContextMainOperations | | | hadoop.fs.TestGlobPaths | | | hadoop.fs.viewfs.TestViewFsFileStatusHdfs | | | hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens | | | hadoop.fs.viewfs.TestViewFsAtHdfsRoot | | | hadoop.TestGenericRefresh | | | hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer | | | hadoop.fs.shell.TestHdfsTextCommand | | | hadoop.cli.TestHDFSCLI | | | hadoop.hdfs.TestReplaceDatanodeOnFailure | | | hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd | | | hadoop.fs.TestSymlinkHdfsDisable | | | hadoop.hdfs.server.namenode.TestFSImage | | | hadoop.fs.viewfs.TestViewFileSystemHdfs | | | hadoop.hdfs.TestDFSInotifyEventInputStream | | | hadoop.hdfs.server.namenode.TestCheckpoint | | Timed out tests | org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing | | | org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12739807/HDFS-8238.003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / b039e69 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11370/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11370/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11370/artifact/patchprocess/testrun_hadoop-hdfs-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11370/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11370/console | This message was automatically generated. > Move ClientProtocol to the hdfs-client > -------------------------------------- > > Key: HDFS-8238 > URL: https://issues.apache.org/jira/browse/HDFS-8238 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: build > Reporter: Haohui Mai > Assignee: Takanobu Asanuma > Attachments: HDFS-8238.000.patch, HDFS-8238.001.patch, > HDFS-8238.002.patch, HDFS-8238.003.patch > > > The {{ClientProtocol}} class defines the RPC protocol between the NN and the > client. This jira proposes to move it into the hdfs-client module. > The jira needs to move: > * {{o.a.h.hdfs.server.namenode.SafeModeException}} and > {{o.a.h.hdfs.server.namenode.NotReplicatedYetException}} to the hdfs-client > package > * Remove the reference of {{DistributedFileSystem}} in the javadoc > * Create a copy of {{DFSConfigKeys.DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY}} in > {{HdfsClientConfigKeys}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)