[ 
https://issues.apache.org/jira/browse/HDFS-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588484#comment-14588484
 ] 

Andrew Wang commented on HDFS-8605:
-----------------------------------

Hey Vinay, couple nitty comments:

* Could we spell out "To" instead of "2"?
* SLF4J and template style logging is the standard for new logging code, rather 
than the isDebugEnabledCheck and string concatenation.

+1 otherwise though, thanks for working on this.

> Merge Refactor of DFSOutputStream from HDFS-7285 branch
> -------------------------------------------------------
>
>                 Key: HDFS-8605
>                 URL: https://issues.apache.org/jira/browse/HDFS-8605
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8605-01.patch
>
>
> Merging the refactor of DFSOutput stream from HDFS-7285 branch
> This will make things easy while merging changes from trunk periodically to 
> HDFS-7285.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to