[
https://issues.apache.org/jira/browse/HDFS-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588718#comment-14588718
]
Jing Zhao commented on HDFS-8608:
---------------------------------
Thanks for working on this, Zhe! The patch looks pretty good to me. One nitty
pick: we can check if {{getStoredBlock(block)}} returns null before calling
{{decrement}}.
{code}
@@ -3181,7 +3182,7 @@ void addBlock(DatanodeStorageInfo storageInfo, Block
block, String delHint)
//
// Modify the blocks->datanode map and node's map.
//
- pendingReplications.decrement(block, node);
+ pendingReplications.decrement(getStoredBlock(block), node);
processAndHandleReportedBlock(storageInfo, block, ReplicaState.FINALIZED,
delHintNode);
}
{code}
Other than this +1.
> Merge HDFS-7912 to trunk (track BlockInfo instead of Block in
> UnderReplicatedBlocks and PendingReplicationBlocks)
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-8608
> URL: https://issues.apache.org/jira/browse/HDFS-8608
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-8608.00.patch, HDFS-8608.01.patch
>
>
> This JIRA aims to merges HDFS-7912 into trunk to minimize final patch when
> merging the HDFS-7285 (erasure coding) branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
