[jira] [Commented] (HDFS-6249) Output AclEntry in PBImageXmlWriter

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589254#comment-14589254
 ] 

Akira AJISAKA commented on HDFS-6249:
-------------------------------------

Thanks [~surendrasingh] for taking this issue.
1. Would you move the following code into {{dumpAcls}} method to reduce code 
duplication?
{code}
    ImmutableList<AclEntry> aclEntryList = dumpAcls(f.getAcl());
    if (aclEntryList.size() > 0) {
      out.print("<acls>");
      for (AclEntry aclEntry : aclEntryList) {
        o("acl", aclEntry.toString());
      }
      out.print("</acls>");
    }
{code}
2. Would you add a test case such as 
{{TestOfflineImageViewer#testPBImageXmlWriter}} to 
TestOfflineImageViewerForAcl.java?

> Output AclEntry in PBImageXmlWriter
> -----------------------------------
>
>                 Key: HDFS-6249
>                 URL: https://issues.apache.org/jira/browse/HDFS-6249
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: tools
>    Affects Versions: 2.4.0
>            Reporter: Akira AJISAKA
>            Assignee: surendra singh lilhore
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-6249.patch
>
>
> It would be useful if {{PBImageXmlWriter}} outputs {{AclEntry}} also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)