[ 
https://issues.apache.org/jira/browse/HDFS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931201#action_12931201
 ] 

Todd Lipcon commented on HDFS-1152:
-----------------------------------

I'm not certain if this has been seen in production, but it's clearly incorrect 
in 0.20-append. Wouldn't call it a blocker, since it's a pretty narrow race 
that hasn't been observed, but don't see a reason *not* to commit either.

> appendFile does not recheck lease in second synchronized block
> --------------------------------------------------------------
>
>                 Key: HDFS-1152
>                 URL: https://issues.apache.org/jira/browse/HDFS-1152
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20-append, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: appendFile-recheck-lease.txt, hdfs-1152.txt
>
>
> FSN.appendFile is made up of two synchronized sections. The second section 
> assumes that the file has not gotten modified during the unsynchronized part 
> in between. We should recheck the lease in the second block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to