[
https://issues.apache.org/jira/browse/HDFS-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-8457:
--------------------------------
Attachment: HDFS-8457.06-07.delta
Thanks for the detailed review [~jnp]! v7 patch addresses all your comments.
For #1, I wanted to avoid repeated reflection but having the reflection is
probably cleaner to read.
bq. What is the reason for not moving public List<FinalizedReplica>
getFinalizedBlocks(String bpid) to DatasetSpi?
This method is only used by the block scanner which is an FsDataset-specific
implementation. Also I am not sure the concept of 'finalize' will be helpful
for other Ozone containers.
One additional change in the v7 patch is that I moved {{initReplicaRecovery}}
and {{updateReplicaUnderRecovery}} back to FsDatasetSpi. We can revisit this
when we get to replica recovery for Ozone containers.
> Ozone: Refactor FsDatasetSpi to pull up HDFS-agnostic functionality into
> parent interface
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-8457
> URL: https://issues.apache.org/jira/browse/HDFS-8457
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8457-HDFS-7240.01.patch,
> HDFS-8457-HDFS-7240.02.patch, HDFS-8457-HDFS-7240.03.patch,
> HDFS-8457-HDFS-7240.04.patch, HDFS-8457-HDFS-7240.05.patch,
> HDFS-8457-HDFS-7240.06.patch
>
>
> FsDatasetSpi can be split up into HDFS-specific and HDFS-agnostic parts. The
> HDFS-specific parts can continue to be retained in FsDataSpi while those
> relating to volume management, block pools and upgrade can be moved to a
> parent interface.
> There will be no change to implementations of FsDatasetSpi.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
