[
https://issues.apache.org/jira/browse/HDFS-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593759#comment-14593759
]
Chris Nauroth commented on HDFS-8448:
-------------------------------------
Hi [~anu]. This patch looks pretty good! I have just a few minor suggestions.
# Can we remove the default constructor in {{OzoneException}}? In general,
it's better practice to build an exception with a descriptive message and
optionally a root cause exception. If a default constructor is available, then
it might encourage writing code that doesn't provide a descriptive message.
# Do you think it makes sense for the *Args classes to be made immutable by
moving all member initialization into the constructors and removing the setter
methods?
# In general, there are inaccuracies in JavaDoc. I saw missing parameters or
incorrect parameters in several of the classes. test-patch will catch these
during the JavaDoc check, or you could review manually now.
BTW, I just heard from Apache infrastructure that Jenkins got really backed up.
Jobs are flowing now, but it might take a while sitting in the queue.
> Create REST Interface for Volumes
> ---------------------------------
>
> Key: HDFS-8448
> URL: https://issues.apache.org/jira/browse/HDFS-8448
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: hdfs-8448-HDFS-7240.003.patch,
> hdfs-8448-hdfs-7240.001.patch, hdfs-8448-hdfs-7240.002.patch
>
>
> Create REST interfaces as specified in the architecture document.
> This Jira is for creating the Volume Interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
