[
https://issues.apache.org/jira/browse/HDFS-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595516#comment-14595516
]
Akira AJISAKA commented on HDFS-8462:
-------------------------------------
Thanks [~jagadesh.kiran] for updating the patch. Minor comment:
{code:title=TestOfflineImageViewerForXAttr.java}
WebImageViewer viewer = new WebImageViewer(
NetUtils.createSocketAddr("localhost:0"));
try {
viewer.initServer(originalFsimage.getAbsolutePath());
...
} finally {
// shutdown the viewer
viewer.close();
}
{code}
Would you use try-with-resources instead of try-finally? I'm +1 if that is
addressed.
> Implement GETXATTRS and LISTXATTRS operation for WebImageViewer
> ---------------------------------------------------------------
>
> Key: HDFS-8462
> URL: https://issues.apache.org/jira/browse/HDFS-8462
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Akira AJISAKA
> Assignee: Jagadesh Kiran N
> Attachments: HDFS-8462-00.patch, HDFS-8462-01.patch,
> HDFS-8462-02.patch, HDFS-8462-03.patch
>
>
> In Hadoop 2.7.0, WebImageViewer supports the following operations:
> * {{GETFILESTATUS}}
> * {{LISTSTATUS}}
> * {{GETACLSTATUS}}
> I'm thinking it would be better for administrators if {{GETXATTRS}} and
> {{LISTXATTRS}} are supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
