[
https://issues.apache.org/jira/browse/HDFS-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596432#comment-14596432
]
Rakesh R commented on HDFS-8643:
--------------------------------
Following warnings are not related to this patch:
- Whitespace: the reported problem is not in the scope of the patch, line no:
58 is next line to the proposed changes in the patch
{code}
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshottableDirectoryStatus.java:58:
{code}
- checkstyle: the reported problem is already exists in the present code.
{code}
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshottableDirectoryStatus.java:62:10:
More than 7 parameters (found 12).
{code}
- Test case failure: It looks like not related to the patch.
{code}
https://builds.apache.org/job/PreCommit-HDFS-Build/11433/testReport/org.apache.hadoop.hdfs.server.blockmanagement/TestBlocksWithNotEnoughRacks/testSufficientlyReplBlocksUsesNewRack/
java.lang.RuntimeException: java.util.zip.ZipException: invalid code lengths set
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:122)
at java.io.FilterInputStream.read(FilterInputStream.java:83)
at
org.apache.xerces.impl.XMLEntityManager$RewindableInputStream.read(Unknown
Source)
at org.apache.xerces.impl.XMLEntityManager.setupCurrentEntity(Unknown
Source)
at
org.apache.xerces.impl.XMLVersionDetector.determineDocVersion(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:150)
at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2546)
at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2534)
at
org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2605)
at
org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2558)
at
org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2469)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:1205)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:1177)
at org.apache.hadoop.conf.Configuration.setLong(Configuration.java:1422)
at
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks.getConf(TestBlocksWithNotEnoughRacks.java:63)
at
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks.testSufficientlyReplBlocksUsesNewRack(TestBlocksWithNotEnoughRacks.java:88)
{code}
> Add snapshot names list to SnapshottableDirectoryStatus
> -------------------------------------------------------
>
> Key: HDFS-8643
> URL: https://issues.apache.org/jira/browse/HDFS-8643
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8643-00.patch
>
>
> The idea of this jira to enhance {{SnapshottableDirectoryStatus}} by adding
> {{snapshotNames}} attribute into it, presently it has the {{snapshotNumber}}.
> IMHO this would help the users to get the list of snapshot names created.
> Also, the snapshot names can be used while renaming or deleting the snapshots.
> {code}
> org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus.java
> /**
> * @return Snapshot names for the directory.
> */
> public List <String> getSnapshotNames() {
> return snapshotNames;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
