[
https://issues.apache.org/jira/browse/HDFS-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597597#comment-14597597
]
Walter Su commented on HDFS-8619:
---------------------------------
2. {{SafeReplication}} is correct in {{incrementSafeBlockCount}}, but is
incorrect in {{decrementSafeBlockCount}}
3.
{code}
//FSNameSystem#listCorruptFileBlocks(..)
if (inode != null && blockManager.countNodes(blk).liveReplicas() == 0) {
{code}
We should compare liveReplicas with expected data block number(considering file
smaller than a full stripe). Please take a look at HDFS-8567. It add a helper
function in BlockInfoStriped to get expected data block number.
> Erasure Coding: revisit replica counting for striped blocks
> -----------------------------------------------------------
>
> Key: HDFS-8619
> URL: https://issues.apache.org/jira/browse/HDFS-8619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8619.000.patch
>
>
> Currently we use the same {{BlockManager#countNodes}} method for striped
> blocks, which simply treat each internal block as a replica. However, for a
> striped block, we may have more complicated scenario, e.g., we have multiple
> replicas of the first internal block while we miss some other internal
> blocks. Using the current {{countNodes}} methods can lead to wrong decision
> in these scenarios.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
