[
https://issues.apache.org/jira/browse/HDFS-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598107#comment-14598107
]
Chris Douglas commented on HDFS-8435:
-------------------------------------
+1 overall (maybe retry Jenkins?). Quick question on this change (nit: space
after the "if"):
{noformat}
- EnumSet<CreateFlag> flags = params.overwrite() ?
- EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE)
- : EnumSet.of(CreateFlag.CREATE);
-
+ EnumSet<CreateFlag> flags = params.createFlag();
+ if(flags.equals(EMPTY_CREATE_FLAG)) {
+ flags = params.overwrite() ?
+ EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE)
+ : EnumSet.of(CreateFlag.CREATE);
+ }
{noformat}
If the flags are non-empty but {{overwrite}} is among the params, should this
add {{OVERWRITE}} to the flags, or require that it be present?
> createNonRecursive support needed in WebHdfsFileSystem to support HBase
> -----------------------------------------------------------------------
>
> Key: HDFS-8435
> URL: https://issues.apache.org/jira/browse/HDFS-8435
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: webhdfs
> Affects Versions: 2.6.0
> Reporter: Vinoth Sathappan
> Assignee: Jakob Homan
> Attachments: HDFS-8435-branch-2.7.001.patch, HDFS-8435.001.patch
>
>
> The WebHdfsFileSystem implementation doesn't support createNonRecursive.
> HBase extensively depends on that for proper functioning. Currently, when the
> region servers are started over web hdfs, they crash due with -
> createNonRecursive unsupported for this filesystem class
> org.apache.hadoop.hdfs.web.SWebHdfsFileSystem
> at
> org.apache.hadoop.fs.FileSystem.createNonRecursive(FileSystem.java:1137)
> at
> org.apache.hadoop.fs.FileSystem.createNonRecursive(FileSystem.java:1112)
> at
> org.apache.hadoop.fs.FileSystem.createNonRecursive(FileSystem.java:1088)
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.init(ProtobufLogWriter.java:85)
> at
> org.apache.hadoop.hbase.regionserver.wal.HLogFactory.createWriter(HLogFactory.java:198)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
