[
https://issues.apache.org/jira/browse/HDFS-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600216#comment-14600216
]
Zhe Zhang commented on HDFS-8655:
---------------------------------
Thanks Haohui and Jing for the helpful comments. Yes I think it's a good idea
to keep {{INodeFile}} changes in EC branch as it's small, and not as applicable
to trunk as other refactor patches we are merging.
I will make the changes Jing suggested to the rebased EC branch patch. Should
we also rename {{blocks}} to {{contiguousBlocks}}?
> Refactor accesses to INodeFile#blocks
> -------------------------------------
>
> Key: HDFS-8655
> URL: https://issues.apache.org/jira/browse/HDFS-8655
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-8655.00.patch
>
>
> When enabling INodeFile support for striped blocks (mainly in HDFS-7749),
> HDFS-7285 branch generalized the concept of blocks under an inode. Now
> {{INodeFile#blocks}} only contains contiguous blocks of an inode. This JIRA
> separates out code refactors for this purpose. Two main changes:
> # Rename {{setBlocks}} to {{setContiguousBlocks}}
> # Replace direct accesses to {{INodeFile#blocks}} to {{getBlocks}}
> It also contains some code cleanups introduced in the branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
