[
https://issues.apache.org/jira/browse/HDFS-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600382#comment-14600382
]
Zhe Zhang commented on HDFS-8058:
---------------------------------
[~jingzhao] [~hitliuyi] Maybe we should revisit this approach? I posted a
[comment |
https://issues.apache.org/jira/browse/HDFS-7285?focusedCommentId=14600362&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14600362]
under the master JIRA. Per above discussion, when adding/setting individual
blocks, it's not hard to guarantee the striped/contiguous type. The trickiest
part is to set the entire array. We can probably build some other abstractions.
Either an interface for {{BIStriped}} and {{BIUCStriped}}, or something like
{{StripedBlocks}}, which is an array with only striped blocks?
> Erasure coding: use BlockInfo[] for both striped and contiguous blocks in
> INodeFile
> -----------------------------------------------------------------------------------
>
> Key: HDFS-8058
> URL: https://issues.apache.org/jira/browse/HDFS-8058
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-8058.001.patch, HDFS-8058.002.patch
>
>
> This JIRA is to use {{BlockInfo[] blocks}} for both striped and contiguous
> blocks in INodeFile.
> Currently {{FileWithStripedBlocksFeature}} keeps separate list for striped
> blocks, and the methods there duplicate with those in INodeFile, and current
> code need to judge {{isStriped}} then do different things. Also if file is
> striped, the {{blocks}} in INodeFile occupy a reference memory space.
> These are not necessary, and we can use the same {{blocks}} to make code more
> clear.
> I keep {{FileWithStripedBlocksFeature}} as empty for follow use: I will file
> a new JIRA to move {{dataBlockNum}} and {{parityBlockNum}} from
> *BlockInfoStriped* to INodeFile, since ideally they are the same for all
> striped blocks in a file, and store them in block will waste NN memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
