[
https://issues.apache.org/jira/browse/HDFS-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601809#comment-14601809
]
Arpit Agarwal commented on HDFS-7390:
-------------------------------------
Thanks for the updated patch Benoy. +1 for the v7 patch.
Couple of things you can fix while committing:
# {{StorageTypeStatsMap#get}} should wrap the returned map using
{{Collections#unmodifiableMap}} to avoid inadvertent modification.
# HeartbeatManager:490 {{entry:}} missing space before {{:}}.
> Provide JMX metrics per storage type
> ------------------------------------
>
> Key: HDFS-7390
> URL: https://issues.apache.org/jira/browse/HDFS-7390
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.5.2
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Labels: BB2015-05-TBR
> Attachments: HDFS-7390-003.patch, HDFS-7390-004.patch,
> HDFS-7390-005.patch, HDFS-7390-006.patch, HDFS-7390-007.patch,
> HDFS-7390.patch, HDFS-7390.patch
>
>
> HDFS-2832 added heterogeneous support. In a cluster with different storage
> types, it is useful to have metrics per storage type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
