[
https://issues.apache.org/jira/browse/HDFS-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601928#comment-14601928
]
Anu Engineer commented on HDFS-8661:
------------------------------------
Looks good, + 1 (Non-Binding )
Small nits :
{{DataNode.java#prepareVolumeForAddition}} Missing java doc
{{DatasetSpi.java#recordFailedVolume}} missing javaDoc
{{DatasetSpi.java#removeVolumes}} -- @param clearFailure Documentation is
removed, did you intend to do this ?
{{DatasetXceiver.java}} Spelling : unitialized
Plus you have a bunch of white space warnings, which is shows up in the test
run.
> DataNode should filter the set of NameSpaceInfos passed to Datasets
> -------------------------------------------------------------------
>
> Key: HDFS-8661
> URL: https://issues.apache.org/jira/browse/HDFS-8661
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: HDFS-7240
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8661-HDFS-7240.01.patch
>
>
> {{DataNode#refreshVolumes}} passes the list of NamespaceInfos to each dataset
> when adding new volumes.
> This list should be filtered by the correct NodeType(s) for each dataset.
> e.g. in a shared HDFS+Ozone cluster, FsDatasets would be notified of NN block
> pools and Ozone datasets would be notified of Ozone block pool(s).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
