[ 
https://issues.apache.org/jira/browse/HDFS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932307#action_12932307
 ] 

Jakob Homan commented on HDFS-1500:
-----------------------------------

Why was the one-line needed to correct the test failure not the entirety of 
this patch?   The extra changes made to the tests were out of the scope of the 
JIRA, which got opened and resolved in an hour.  By moving the fail statements 
out of the individual sub-tests, it is now more difficult to see which sub-test 
failed.  Had this been called out as being part of this patch, I would have 
raised concerns about this change.

> TestOfflineImageViewer failing on trunk
> ---------------------------------------
>
>                 Key: HDFS-1500
>                 URL: https://issues.apache.org/jira/browse/HDFS-1500
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test, tools
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1500.txt
>
>
> Testcase: testOIV took 22.679 sec
>       FAILED
> Failed reading valid file: No image processor to read version -26 is 
> available.
> junit.framework.AssertionFailedError: Failed reading valid file: No image 
> processor to read version -26 is available.
>       at 
> org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer.outputOfLSVisitor(TestOfflineImageViewer.java:171)
>       at 
> org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer.testOIV(TestOfflineImageViewer.java:86)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to