[ 
https://issues.apache.org/jira/browse/HDFS-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603963#comment-14603963
 ] 

Arpit Agarwal commented on HDFS-8681:
-------------------------------------

bq.  we did not change the default scan period's value of 0,
Instead of changing the default can we just change the check to be 
{{conf.scanPeriodMs >= 0}}? Is there any part of HDFS-7430 that would be broken 
if the scanPeriod is 0?

> BlockScanner is incorrectly disabled by default
> -----------------------------------------------
>
>                 Key: HDFS-8681
>                 URL: https://issues.apache.org/jira/browse/HDFS-8681
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Andrew Wang
>            Assignee: Colin Patrick McCabe
>            Priority: Blocker
>
> This code is used to check whether the block scanner is enabled:
> {noformat}
>   public boolean isEnabled() {
>     return (conf.scanPeriodMs) > 0 && (conf.targetBytesPerSec > 0);
>   }
> {noformat}
> Unfortunately, when this was introduced, we did not change the default scan 
> period's value of 0, which means by default the BlockScanner is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to