[
https://issues.apache.org/jira/browse/HDFS-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated HDFS-718:
-----------------------------
Attachment: HDFS-718-4.patch
Here's an updated patch addressing Boris' comment and using the new
MiniDFSCluster builder.
Test-patch is fine (with known-bad audit warning)
{noformat} [exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 98 release audit
warnings (more than the trunk's current 1 warnings).
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.{noformat}
I'd like to get this into 22. Since the change in this code only affected the
unit test, which has been verified, I'm ready to go ahead and commit it. How's
that sound?
> configuration parameter to prevent accidental formatting of HDFS filesystem
> ---------------------------------------------------------------------------
>
> Key: HDFS-718
> URL: https://issues.apache.org/jira/browse/HDFS-718
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Environment: Any
> Reporter: Andrew Ryan
> Assignee: Andrew Ryan
> Priority: Minor
> Attachments: HDFS-718-3.patch, HDFS-718-4.patch,
> HDFS-718.patch-2.txt, HDFS-718.patch.txt
>
>
> Currently, any time the NameNode is not running, an HDFS filesystem will
> accept the 'format' command, and will duly format itself. There are those of
> us who have multi-PB HDFS filesystems who are really quite uncomfortable with
> this behavior. There is "Y/N" confirmation in the format command, but if the
> formatter genuinely believes themselves to be doing the right thing, the
> filesystem will be formatted.
> This patch adds a configuration parameter to the namenode,
> dfs.namenode.support.allowformat, which defaults to "true," the current
> behavior: always allow formatting if the NameNode is down or some other
> process is not holding the namenode lock. But if
> dfs.namenode.support.allowformat is set to "false," the NameNode will not
> allow itself to be formatted until this config parameter is changed to "true".
> The general idea is that for production HDFS filesystems, the user would
> format the HDFS once, then set dfs.namenode.support.allowformat to "false"
> for all time.
> The attached patch was generated against trunk and +1's on my test machine.
> We have a 0.20 version that we are using in our cluster as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
