[jira] [Commented] (HDFS-8468) 2 RPC calls for every file read in DFSClient#open(..) resulting in double Audit log entries

[Yi Liu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605601#comment-14605601
 ] 

Yi Liu commented on HDFS-8468:
------------------------------

Thanks Vinay for working on this.   
The patch looks good to me. One nit:
{code}
+      LocatedBlocks locatedBlocks = getLocatedBlocks(src, 0);
+      if (locatedBlocks != null) {
+        ECSchema schema = locatedBlocks.getECSchema();
{code}
We can add a {{else}} after the if
{code}
else {
  throw new IOException("Cannot open filename " + src);
}
{code}

> 2 RPC calls for every file read in DFSClient#open(..) resulting in double 
> Audit log entries
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8468
>                 URL: https://issues.apache.org/jira/browse/HDFS-8468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8468-HDFS-7285.patch
>
>
> In HDFS-7285 branch, 
> To determine whether file is striped/not and get the Schema for the file, 2 
> RPCs done to Namenode.
> This is resulting in double audit logs for every file read for both 
> striped/non-striped.
> This will be a major impact in size of audit logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)