[
https://issues.apache.org/jira/browse/HDFS-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609128#comment-14609128
]
Zhe Zhang commented on HDFS-8652:
---------------------------------
Thanks Jing for the work! The patch looks good to me as well. I only have 1
question:
# The below change is not trivial. Why don't we need to check {{liveReplicas}}
anymore? If so, should we update the comment to match the logic?
{code}
- } else if (nr.liveReplicas() >= 1) {
+ } else {
// If we have at least one copy on a live node, then we can delete it.
addToInvalidates(b.corrupted, dn);
removeStoredBlock(b.stored, node);
{code}
> Track BlockInfo instead of Block in CorruptReplicasMap
> ------------------------------------------------------
>
> Key: HDFS-8652
> URL: https://issues.apache.org/jira/browse/HDFS-8652
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8652.000.patch, HDFS-8652.001.patch
>
>
> Currently {{CorruptReplicasMap}} uses {{Block}} as its key and records the
> list of DataNodes with corrupted replicas. For Erasure Coding since a striped
> block group contains multiple internal blocks with different block ID, we
> should use {{BlockInfo}} as the key.
> HDFS-8619 is the jira to fix this for EC. To ease merging we will use jira to
> first make changes in trunk/branch-2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
