[
https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612024#comment-14612024
]
Xiaoyu Yao commented on HDFS-8711:
----------------------------------
Patch LGTM. A few comments:
1. "Available storage type are " should be "Available storage types are"
2. Can you add a unit test for the change?
> setSpaceQuota command should print the available storage type when input
> storage type is wrong
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-8711
> URL: https://issues.apache.org/jira/browse/HDFS-8711
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.7.0
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-8711.patch
>
>
> If input storage type is wrong then currently *setSpaceQuota* give exception
> like this.
> {code}
> ./hdfs dfsadmin -setSpaceQuota 10000000 -storageType COLD /testDir
> setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD
> {code}
> It should be
> {code}
> setSpaceQuota: Storage type COLD not available. Available storage type are
> [SSD, DISK, ARCHIVE]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
