[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612312#comment-14612312
]
Andrew Wang commented on HDFS-8712:
-----------------------------------
LGTM +1 pending, will help reduce the # of checkstyle warnings too.
> Remove "public" and "abstract" modifiers in FsVolumeSpi and FsDatasetSpi
> ------------------------------------------------------------------------
>
> Key: HDFS-8712
> URL: https://issues.apache.org/jira/browse/HDFS-8712
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Trivial
> Attachments: HDFS-8712.000.patch
>
>
> In [Java Language Specification
> 9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
> bq. It is permitted, but discouraged as a matter of style, to redundantly
> specify the public and/or abstract modifier for a method declared in an
> interface.
> {{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
> warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
