[ 
https://issues.apache.org/jira/browse/HDFS-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613063#comment-14613063
 ] 

Harsh J commented on HDFS-8660:
-------------------------------

This would be an excellent improvement for certain performance troubleshooting. 
In looking for more such "Slow" messages, the following matches may also need 
similar changes:

The "Slow ReadProcessor" message in DataStreamer.java can benefit from a block 
ID.
The "Slow waitForAckedSeqno" in DataStreamer.java message too could benefit 
from a block ID as well as a nodes list.

Just Block ID can also be added into the below messages under 
BlockReceiver.java:

"Slow flushOrSync"
"Slow BlockReceiver write data to disk"
"Slow manageWriterOsCache"

DN Mirror Host+Block ID can both be added into the below message under 
BlockReceiver.java:

"Slow PacketResponder send ack to upstream took"

Could you check if these are possible to do as part of the same JIRA as simple 
changes too?

> Slow write to packet mirror should log which mirror and which block
> -------------------------------------------------------------------
>
>                 Key: HDFS-8660
>                 URL: https://issues.apache.org/jira/browse/HDFS-8660
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Hazem Mahmoud
>            Assignee: Hazem Mahmoud
>
> Currently, log format states something similar to: 
> "Slow BlockReceiver write packet to mirror took 468ms (threshold=300ms)"
> For troubleshooting purposes, it would be good to have it mention which block 
> ID it's writing as well as the mirror (DN) that it's writing it to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to